afbora / kirby-minify-html

Enable minify HTML output for Kirby 3 and 4

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Collision with `getkirby/layouts` plugin

S1SYPHOS opened this issue · comments

.. and I can't figure out why! What could possible pitfalls be? On many other websites, I install it and it just worksTM - I tried var_dumping from inside the plugin, nothing - I don't even know if it's loaded - and if not, why ..

I appreciate all pointers,

cheers
S1SYPHOS

I'm not sure how can I help you. I need more information, setup, details etc..

I guess it collides with getkirby/layouts plugin, which also extends the core component template!

Good point. I think it's difficult that using both component same time.

I guess at this point, there's no way of using both except adding support for one another .. and building some kind of HTML minification / your plugin into the core would violate Kirby's premise of maximum user freedom BUT on the other hand, making minification 'pluggable' and using your setup as default inside Template would be great IMHO

Definitely you're right! We need more hooks to more pluggable For ex: page.render:before, page.render:after or something like that.

May be @bastianallgeier give us an idea about that 🙏

.. and I guess it would not even be that much work (yeah, easy coming from me, sorry), but I imagine it's not that much - which makes it more likely to be implemented which in turn makes me very happy right now 😃

For now I've added an idea about that https://kirby.nolt.io/419