afbora / kirby-minify-html

Enable minify HTML output for Kirby 3 and 4

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Allow options of type array

timnarr opened this issue · comments

Hi Ahmet,

I want to use the doMakeSameDomainsLinksRelative option and pass an array with domains to the minifier, like this:
'doMakeSameDomainsLinksRelative' => ['https://example.com'],

But using this option will lead to an TypeError:
"voku\helper\HtmlMin::doMakeSameDomainsLinksRelative(): Argument #1 ($localDomains) must be of type array, bool given ..."

What do you think? Could this be customized?

Thanks for your time and the great plugin.
Tim

Fixed on v1.4.0 release. Could you test please?

https://github.com/afbora/kirby-minify-html/releases/tag/1.4.0

Thank you for your quick help! The new version works fine for me :)