insert_point_site fail

[Max Chen]

I try to build the cpp example on win10 with vs2019. build ok, but even insert first point site made program crash.
In medial axis example, it failed at line 27:
int id0 = vd->insert_point_site(p0);

Is that openvoronoi is not support windows? Or I use the wrong version of boost ?

[Koen Schmeets]

I got the same on macOS (running any of the tests)

I wonder if it works on Linux since in CI things seem to work fine.

[Koen Schmeets]

I can confirm that it works correctly on linux, and the this line seems to have an effect on the macOS / windows issue:

https://github.com/aewallin/openvoronoi/blob/master/src/common/halfedgediagram.hpp#L277

When that is commented out, things >seem< to work. perhaps @aewallin can tell us more with that hint?

EDIT: When that is commented out, the minimal example seems to work, others don't segfault anymore but the graph is invalid, so it seems something is working differently in linux vs macos, and it might have to do with edge invalidation, but that is all I can figure out with my limited C++ / boost::graph knowledge ;)

[Anders Wallin]

Does macOS always use Clang as the compiler? gcc vs. clang could be tested on linux also.
I can try to take a look at some point - but it's years since I worked with this code seriously..

[Manuel Massing]

Hi Anders, have you seen my PR #53 ? It should fix this issue.

[Anders Wallin]

now merged. but I probably won't have time to test in the next week or so..

[Manuel Massing]

Thanks!