aesara-devs / aesara

Aesara is a Python library for defining, optimizing, and efficiently evaluating mathematical expressions involving multi-dimensional arrays.

Home Page:https://aesara.readthedocs.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Use `absolute` instead of `abs`

rlouf opened this issue · comments

Hey is this right place?
Where I should make changs of deprecate

_abs = builtins.abs

Line 1049 in this file. If you want to see what kind of changes you would need to make you can check out #1414.

Thanks for giving that refference.
Like true_div changed to true_divide I need to change do same with abs
Correct me if wrong-

  1. Need to change abs to absolute throughout the codebase. I made changes in commit.
  2. Add deprecate to abs

Sounds about right. You can look at this PR to have an idea of all the places where you will have to make changes.

Hi @rlouf , are you working on this issue?

Not at the moment