Use `absolute` instead of `abs`
rlouf opened this issue · comments
And deprecate aesara.tensor.math.abs
.
https://numpy.org/doc/stable/reference/generated/numpy.absolute.html#numpy.absolute
Hey is this right place?
Where I should make changs of deprecate
Line 50 in 71e2f1e
Line 1049 in this file. If you want to see what kind of changes you would need to make you can check out #1414.
Thanks for giving that refference.
Like true_div
changed to true_divide
I need to change do same with abs
Correct me if wrong-
- Need to change
abs
toabsolute
throughout the codebase. I made changes in commit. - Add deprecate to
abs
Sounds about right. You can look at this PR to have an idea of all the places where you will have to make changes.
Hi @rlouf , are you working on this issue?
Not at the moment