Set `filterwarnings` to `error` in the tests

Question

Set `filterwarnings` to `error` in the tests

brandonwillard opened this issue 2 years ago · comments

Brandon T. Willard commented 2 years ago

Our tests should not allow un-caught/checked warnings.

The addition to setup.cfg mentioned here should be sufficient. We'll need to update our tests to prevent them from failing, though.

Rémi Louf · Answer 1 · Fri Aug 26 2022 00:12:37 GMT+0800 (China Standard Time)

It looks like it was done in this commit: dde2d83

I've tried only specifying error, and the tests fail due to a DeprecationWarning in aesara, while they pass with the current version of setup.cfg. Is that expected?

Brandon T. Willard · Answer 2 · Fri Aug 26 2022 00:23:10 GMT+0800 (China Standard Time)

It looks like it was done in this commit: dde2d83

Oh, yeah, this one can probably be closed then.

I've tried only specifying error, and the tests fail due to a DeprecationWarning in aesara, while they pass with the current version of setup.cfg. Is that expected?

The current settings should make warnings emitted from within aesara fail. I didn't enable all errors because some dependency was emitting a warning and it's mostly out of our control.

Rémi Louf · Answer 3 · Fri Aug 26 2022 01:10:21 GMT+0800 (China Standard Time)

The current settings should make warnings emitted from within aesara fail. I didn't enable all errors because some dependency was emitting a warning and it's mostly out of our control.

Aesara imports numpy.disutils which in turn raises a DeprecationWarning, so that's probably what you saw. Otherwise sounds like a sane behavior.