aesara-devs / aehmc

An HMC/NUTS implementation in Aesara

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Use `standard_normal` instead of `normal(0, 1)` function.

zoj613 opened this issue · comments

At

norm_samples = srng.normal(0, 1, size=shape)

normal(0, 1) could be replaced with standard_normal. This change could make it easier to read without thinking about the input values.

I could not find standard_normal in the aesara repo. Where did you find it?

The default values for loc and scale here are respectively 0 and 1, but I am not sure it would improve the code to only specify the size.

I could not find standard_normal in the aesara repo. Where did you find it?

The default values for loc and scale here are respectively 0 and 1, but I am not sure it would improve the code to only specify the size.

https://aesara.readthedocs.io/en/latest/library/tensor/random/basic.html?highlight=RandomStream#aesara.tensor.random.RandomStream claims to behave like np.random.RandomState, so I assumed this function is exposed. Let me close this then.

@zoj613, feel free to add an issue in Aesara for that.

@zoj613, feel free to add an issue in Aesara for that.

Done.