In VS 15.8 pre-2 the context action doesn't add the configure await fix

Question

In VS 15.8 pre-2 the context action doesn't add the configure await fix

DoCode opened this issue 6 years ago · comments

Eli Arbel · Answer 1 · Sun Jun 24 2018 18:13:03 GMT+0800 (China Standard Time)

Hmm, not sure what I can do about that, I'm just using ReSharper APIs. I'd appreciate it if someone could test this with the latest ReSharper EAP (it would probably require compiling a local version of the ConfigureAwaitChecker, updated to use the latest preview SDK).

Manuel · Answer 2 · Sun Jun 24 2018 21:15:46 GMT+0800 (China Standard Time)

Hmmm... I checked the VS 15.7.4 and it's the same issue:

Manuel · Answer 3 · Sun Jun 24 2018 21:22:25 GMT+0800 (China Standard Time)

@aelij is the VS15.7.4 working on your machine?

johnendev · Answer 4 · Mon Jun 25 2018 06:08:08 GMT+0800 (China Standard Time)

Have the same problem with VS15.7.4 an R#2018.1.2. It hasn't worked for me at all in the 2018 wave.

johnendev · Answer 5 · Thu Jun 28 2018 07:56:54 GMT+0800 (China Standard Time)

I have done a bit of debugging. It seems that the delegate to Transactions.Execute is never called. I don't know much about R# plugin development so not sure why that is happening or how to fix it. It's not throwing an exception. The execute call returns a result indicating failure.

ConsiderUsingConfigureAwaitQuickFix.cs:68

Internally the execute call is catching an exception: "Method not found: UsingWriteLock"
It seems that the JIT is failing when processing the delegate.

johnendev · Answer 6 · Thu Jun 28 2018 08:08:48 GMT+0800 (China Standard Time)

Updating to the latest R# SDK fixed the problem for me.

Eli Arbel · Answer 7 · Thu Jun 28 2018 13:01:43 GMT+0800 (China Standard Time)

@johnendev Wanna submit a PR?

Eli Arbel · Answer 8 · Sat Jun 30 2018 19:19:23 GMT+0800 (China Standard Time)

New package v0.14 pushed