Doesn't properly stream logs
aegershman opened this issue · comments
Once it runs "apply changes", the logs don't properly stream
https://opsman-dev-api-docs.cfapps.io/#getting-a-list-of-recent-install-events
As discussed here pivotal-cf/om#141, one option is to run apply-changes to hook in to the current running changes process
EDIT: we could pass in deploy_products: none so that way if apply-changes accidentally (somehow?) triggers without an installation already being in progress, then the worst thing that would happen is the director would be selectively-deployed. Which reduces the amount of time the opsman would be locked out.
Raising this in priority because it somewhat blocks #13 ; if this doesn't stream the logs properly, it will simply return from the task as "success" && release the lock. Then another job will aquire the lock && fail because "an installation is in progress".
We need to get this to stream the logs for the entirety of the "apply-changes", or else it will release the lock too soon
Successfully re-attaches to the running job. Nice!
X-Xss-Protection: 1; mode=block
{
"install": {
"id": 82
}
}
found already running installation...re-attaching (Installation ID: 82, Started: Fri May 11 06:52:37 UTC 2018)
{"type": "step_started", "id": "bosh_product.deploying"}
===== 2018-05-11 06:52:37 UTC Running "/usr/local/bin/bosh --no-color --non-interactive --tty create-env /var/tempest/workspaces/default/deployments/bosh.yml"
Deployment manifest: '/var/tempest/workspaces/default/deployments/bosh.yml'
Deployment state: '/var/tempest/workspaces/default/deployments/bosh-state.json'
Nice good work I this improvement
I, too, this improvement