Rework default names
adya opened this issue · comments
Currently default titles and obscurities are being stored within NNDData
.
This leads to the need for cumbersome checks and storing extra data in cosave when it's not needed there.
To mitigate this NNDData::UpdateDisplayName()
and NNDData::GetName()
should be updated to receive an Actor
and be able to substitute GetFullName()
for title when needed.
This would also remove the need to store UpdateMask::kObscurity
since it will never be persisted in a cosave.
To extend this even further we can remove the need for UpdateMask::kDisplayName
, by not saving displayName
either.
It will be reconstructed anyway, so why bother.