Release strategy
fsmanuel opened this issue · comments
My motivation to help working on the addon is to get rid of the annoying deprecations pointed out in #715
In the update process:
I figured out that it's not that simple to get it to work with ember >=4 because the addon and probably the dependencies use the old ember imports and private apis that don't work anymore in ember 4.
That raises the question how we should release new versions to have a happy update path. The latest released version is 4.0.0-beta.12 which was released over a year ago. NPM Versions show that most downloads are for the beta releases.
My suggestion would be to release a version 4.0 that supports ember <=3.28.x and after that work on a new 5.0 release for ember >=4. That would allow us to drop support for ember <=3.28.x in the 5.x branch and make things much easier.
We need to highlight breaking changes from the ember-validators dependency.
I'm happy for more input and opinions.
- Deprecate
volatileoption becausecomputed().volatile()is removed: - Release
4.0.0-beta.13 - Fix ember
4.0issues #717 - #720
- Release
4.0for ember<=3.28.x - Release
5.0for ember>=4 - Replace
ember-font-awesome#731 - Update to ember-cli 4.8 #732
- Update to ember-cli 4.12 #736
- Replace
ember-dataimports #740 - Enable
embroider-safeandembroider-optimizedscenarios #739 - #722
That sounds like a reasonable approach.
This is a crucial dependency of a project I am attempting to update to Ember 4.0.
I will gladly help if told what is necessary. Is there a todo list?
@andsmedeiros not yet. I'll think about it and update the issue.
Sounds like a fine approach. A new release (even another beta) would be appreciated
Bump to humbly request a beta.13 😅
@fsmanuel any progress on this? Can I assist in any way?
Once again requesting a beta release 😅 Who has release creds? @offirgolan
Hey @zeppelin long time no see! I'll have a look at your PRs and anlredy think it'll help a lot.
@fsmanuel thank you for your work. I almost decided to move from ember-cp-validations into other library. You saved us lot of time! Looking forward for 4.0.0-beta.13, 4.x and 5.x versions. We need all of them!
I had made up my mind to move away from ember-cp-validations too because it did not work with Ember 4. Looking forward to the 4.x and 5.x, thanks @fsmanuel !
beta.13 is released. We'll need to replace the deprecated ember-cli-release process, esp since it doesn't work with OTP and the changelog generation seems broken (or maybe the commits aren't properly formatted). Should follow the guidelines in the adopted org.
@knownasilya Thanks a lot.
To all: Would be great to get some help with the release and guidelines as I'm not familiar setting up all that tools.
@gilest @andsmedeiros @enterpub @JenLyndle can you test the 4.0.0-beta.13 release and report bugs or problems if you find any?
@fsmanuel I will be able to test next week. We have a huge app with all kinds of validation, so I'll test it heavily. Thank you so much!
@fsmanuel thanks a lot! I'll test it against my application and let you know of what comes out of it.
@knownasilya Seems like there are not bugs or problems with the beta-13 release. I would say we setup the release and changelog process and rerelease master as v4.0 what do you think?
@knownasilya do you want to do the 4.0 release?
@knownasilya If you give me npm access I can do the release.
Released v4.0.0
#717 is looking for reviewers.
Now that #717 has been merged, are we please able to get a release?
@kiwi-josh I'll do a release in the next days and let you know.
@kiwi-josh released 5.0
As I mentioned before we have huge app with lot of different validation rules, sometimes complex (by using inline validator). We are using Ember 3.28 and Ember-cp-validations 4.0.0 for almost 2 month now, no issues. The upgrade to version 4.0.0 was smooth.
Thank you
@enterpub Thanks for the feedback!