Giters

adopted-ember-addons / ember-cp-validations

Ember computed property based validations

Home Page:https://adopted-ember-addons.github.io/ember-cp-validations/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

generated mocha tests include chai, despite our app not using chai

efx opened this issue · comments

commented

Environment

  • Ember CP Validations Version: (symlinked master as of 4115834)

Steps to Reproduce

  1. ember g validator-test my-validator
  2. In a project that uses ember-mocha, but not chai, it includes chai because of the blueprint.

It would be nice to introspect the project dependencies if it has chai. I wonder how ember-mocha does this right now? Couldn't find the example blueprints in ember-cli from a quick check.

commented

I wonder how ember-mocha does this right now?

ember-mocha itself does not have any testing blueprints, but ember and ember-data both also assume that if you use mocha then you will also use chai.

commented

I'll close this then. I had forgotten about that default behavior. It seems best to address that separately as a feature request to ember-mocha, rather than here.