Github CI tests aren't correctly reported
nicolas-goyon opened this issue · comments
Package version
Adonisjs : 3.0.9
Describe the bug
Hello, in this discussion, I detailed my concern regarding the tests that fail but don't appear to be accurately reported to the GitHub Action. The action displays as successful, despite the presence of failing tests. I'm unsure whether the issue lies with me, Adonis, or the module used by Adonis.
Reproduction repo
The reproduction repo seem to not be available. Private ?
oh my bad, i'll create a new repo for this.
Hi back , here is the new repo, in this repo you can see that the last github action passed correctly even if the second test failed. You could see in the logs that the tests are printed as failed but the step is considered as successfull.
The repo is clean, nothing on it just added one test from the inital npm init [...]
this seems to be related to your NodeJS version ( 14 )
i'm not sure why, but at this point, i would just recommend to upgrade to at least Node 18
node 14 has been deprecated since 2 years
Node 18 is in maintenance mode. Nowadays, you should at least be on Node 20.
Okay it was that, thanks !