Giters

adobe / aepsdk-analytics-ios

Adobe Experience Platform Analytics SDK in Swift

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

make archive fails

markph0204 opened this issue · comments

commented

Expected Behavior

After running make archive, we expect the build to not fail and output frameworks to the build path.

Actual Behavior

Makefile fails to build XCFramework's successfully.

Reproduce Scenario (including but not limited to)

I was able to reproduce on two separate workstations (work and personal) with Xcode versions 12.5.1, 13.0, 13.1

Steps to Reproduce

  1. Get project fresh (git clone) from this repo.
  2. run make archive from terminal

Platform and Version

Mac OS version Big Sur 11.6.1 using Xcode 13.1

Sample Code that illustrates the problem

Not code related.

Logs taken while reproducing problem

Not needed.

Suggestive corrective action for issue

Corrective action is suggested in two areas:

  1. Notify the user to run pod install in the README.md file
  2. the SwiftLint and swiftformat dependencies are missing, and is needed to complete archive. Suggest the user not be required to install it themselves, since CocoaPods is being used for other. Instead leverage CocoaPods to also install both dependencies. This also includes a subtle change in XCodeProject to use them installed via PODS rather than environment. This affords you with ability to "pin" a specific version in future as well for compatibility reasons if ever needed.