Typo within Section 6.2 Organizations and Persons

Question

Typo within Section 6.2 Organizations and Persons

FeLungs opened this issue 5 years ago · comments

Will Hoyt commented 5 years ago

Filing an issue about the xAPI Profiles specification? Please include the following

Which part/parts of the specification are at issue?
2.6
What is your understanding of what the spec means in these parts?
definition of the profile author as an individual or organization
identified by URL with name as a label
type indicates if the URL + Name describe an individual or an organization
How you would like the specification to be improved?
The type property has a type of object when it should be string
takes the value of either "Organization" or "Person"

Andrew Downes · Answer 1 · Sun Jun 09 2019 19:25:13 GMT+0800 (China Standard Time)

+1 good catch. This should be changed to "String"

Jason Haag · Answer 2 · Sun Jun 09 2019 23:35:39 GMT+0800 (China Standard Time)

It's an object. It has a property called "name" that is a string. https://schema.org/Organization

…

On Fri, Jun 7, 2019, 1:02 PM Will Hoyt ***@***.***> wrote: Filing an issue about the *xAPI Profiles* specification? Please include the following - Which part/parts of the specification are at issue? 2.6 - What is your understanding of what the spec means in these parts? definition of the profile author as an individual or organization - identified by URL with name as a label - type indicates if the URL + Name describe an individual or an organization - How you would like the specification to be improved? The type property has a type of object when it should be string - takes the value of either "Organization" or "Individual" — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#249?email_source=notifications&email_token=AAEJSRXGW2JW4B4XINUYZKDPZKPDDA5CNFSM4HVZFQPKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GYJ3OAA>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEJSRXC3E76IYAN5QL7O5DPZKPDDANCNFSM4HVZFQPA> .

Andrew Downes · Answer 3 · Mon Jun 10 2019 00:33:07 GMT+0800 (China Standard Time)

@jhaag75 Isn't this table the description of the organisation object though? The property name "type" and description seem to suggest that this property is a string, as does the fact that there is a name property already. This structure seems unlikely to be intended:

{
  "type": {
    "name": "Andrew Downes"
  },
  "name": "Andrew Downes"
}

Jason Haag · Answer 4 · Mon Jun 10 2019 01:13:58 GMT+0800 (China Standard Time)

I didn't provide enough info. Sorry about that. We are talking about author here (which is defined by https://schema.org/author). It's type is the value of either the "Organization" or "Person" objects, not just any string value. Organization has these properties: https://schema.org/Organization Person has these properties: https://schema.org/Person If you take a look at Section 6.0, for "author" that's where this is coming from. It's listed there as an object. These are actually schema.org objects. The mapping of these to schema.org is in profile-context.jsonld: https://github.com/adlnet/xapi-profiles/blob/master/context/profile-context.jsonld

…

On Sun, Jun 9, 2019 at 11:33 AM Andrew Downes ***@***.***> wrote: @jhaag75 <https://github.com/jhaag75> Isn't this table the description of the organisation object though? The property name "type" and description seem to suggest that this property is a string, as does the fact that there is a name property already. This structure seems unlikely to be intended: "type": { "name": "Andrew Downes" }, "name": "Andrew Downes" }``` — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#249?email_source=notifications&email_token=AAEJSRRFXQMJACMAAHYHXELPZUWEHA5CNFSM4HVZFQPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXINU6A#issuecomment-500226680>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEJSRTQ7SS5UIXMYETMMDLPZUWEHANCNFSM4HVZFQPA> .

Andrew Downes · Answer 5 · Mon Jun 10 2019 19:50:03 GMT+0800 (China Standard Time)

Right, but "Organization" and "Person" are strings, not an objects.

Jason Haag · Answer 6 · Mon Jun 10 2019 20:40:15 GMT+0800 (China Standard Time)

Oh I see now. I did not see that table displayed when reading this via email and misunderstood the question. That should be a string.

…

On Mon, Jun 10, 2019 at 6:50 AM Andrew Downes ***@***.***> wrote: Right, but "Organization" and "Person" are strings, not an objects. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#249?email_source=notifications&email_token=AAEJSRVVT5MMJE5PBNKT5JTPZY5WZA5CNFSM4HVZFQPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXJVJHQ#issuecomment-500389022>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEJSRVNWXG6CNTZI3FLRYDPZY5WZANCNFSM4HVZFQPA> .

Andy Johnson · Answer 7 · Wed Jul 20 2022 04:39:29 GMT+0800 (China Standard Time)

Per the 7/19/2022 meeting, feel free to add to/create a PR for this