Giters

adlnet / lrs-conformance-test-suite

A NodeJS project that tests the MUST requirements of the xAPI Spec and is based on the ADL testing requirements repository. The test suite website can be found here: https://lrstest.adlnet.gov/. The adopters website can be found here: https://adopters.adlnet.gov/

Home Page:https://adlnet.gov/projects/xapi/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[2.0.0] "Duplicate Endpoint Joining in 'getStatementExactPromise' Method

tech-getsmart opened this issue · comments

commented

In test/4.1.6.1-Statement-Resource.js, [Communication/timestamps 2.4.7 GET Statements] Part use 'getStatementExactPromise' method to get returns.

But that request has duplicated endpoint, like this : [http://localhost:8080/xapi/http://localhost:8080/xapi/statements]

I think, this is because in 'getStatementExactPromise' method, it join paths as endpoint, and 'getDocuments' join paths again.

commented

That does seem odd, although I'm not sure why other LRS's would've handled the test then.

It's definitely an oversight though, so I'll update the suite today and see if that helps out?

commented

The live one has been updated, please run your test again -- very sorry for the inconvenience.

I didn't realize that the function in question was only used at that one place, and it still isn't clear why other LRS's (from simple ones like ours to advanced vendor solutions) seemed fine with that clear oversight, but thank you for reporting the issue to us!