Giters

adlnet / lrs-conformance-test-suite

A NodeJS project that tests the MUST requirements of the xAPI Spec and is based on the ADL testing requirements repository. The test suite website can be found here: https://lrstest.adlnet.gov/. The adopters website can be found here: https://adopters.adlnet.gov/

Home Page:https://adlnet.gov/projects/xapi/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

test for LRS rejecting null values

garemoko opened this issue · comments

commented

We found a (recent) statement in Watershed containing the following property:

    "correctResponsesPattern": [ 
        null 
      ]

We should have rejected this because the LRS is required to reject statements with null values outside of extensions: https://github.com/adlnet/xAPI-Spec/blob/master/xAPI-Data.md#lrs-requirements

We're going to fix the issue in Watershed, but since we are passing the conformance test my assumption is that the test suite is not checking that the LRS rejects statements containing null values, or at least is not checking this particular property.

Do we know what the test suite tests in this regard? Should it test null values in every possible property? Should it test more than it tests now?

commented

I can't find where / if this specific case is checked by the suite, so I'm assuming it isn't.

As for that case, should an array with a single value null be considered null itself?

commented

no, but it's still a null value