Node 8 compatibility

[Lctrs]

After upgrading to Node 8 from Node 6, I got the following error in the log when running the test suite.

{
    "name": "console",
    "owner": null,
    "flags": {
        "endpoint": "http://www.lrs.dev/xapi"
    },
    "options": {},
    "rollupRule": "mustPassAll",
    "uuid": "ff7d999e-71bf-4a71-83ec-c5d5c10d3b16",
    "startTime": 1497267812594,
    "endTime": 1497267812617,
    "duration": 23,
    "state": "finished",
    "summary": {
        "total": 1359,
        "passed": 0,
        "failed": 1,
        "version": "1.0.3.12"
    },
    "log": {
        "title": "",
        "name": "",
        "requirement": "",
        "log": "",
        "status": "failed",
        "error": "TypeError: stack[0].getFileName is not a function",
        "tests": []
    }
}

[Andy Creighton]

Looks like there was something broken in one of the dependencies. If you use this command:
npm install git+https://github.comrchadwic/super-request.git#ipc
This will force npm to update to the new improved version of that dependency. New installs should work just fine, but when updating from another version of node use this command to force npm to update that dependency.

[Lctrs]

I finally upgraded super-request to version 1.2.0. Tests are now running but I got the deprecation message below at the end in the console.

$ node bin/console_runner.js -e "http://www.lrs.dev/xapi" -z                                                          
runTests starting
Grep is undefined
directory is  [ 'v1_0_3' ]
Setting up
Accounting for time differential between test suite and lrs
{"total":1359,"passed":75,"failed":3,"version":"1.0.3.12"}
{"total":1359,"passed":159,"failed":3,"version":"1.0.3.12"}
{"total":1359,"passed":266,"failed":3,"version":"1.0.3.12"}
{"total":1359,"passed":341,"failed":3,"version":"1.0.3.12"}
{"total":1359,"passed":408,"failed":3,"version":"1.0.3.12"}
{"total":1359,"passed":519,"failed":3,"version":"1.0.3.12"}
{"total":1359,"passed":635,"failed":3,"version":"1.0.3.12"}
{"total":1359,"passed":746,"failed":3,"version":"1.0.3.12"}
{"total":1359,"passed":836,"failed":3,"version":"1.0.3.12"}
{"total":1359,"passed":908,"failed":4,"version":"1.0.3.12"}
{"total":1359,"passed":965,"failed":4,"version":"1.0.3.12"}
{"total":1359,"passed":1042,"failed":7,"version":"1.0.3.12"}
{"total":1359,"passed":1090,"failed":8,"version":"1.0.3.12"}
{"total":1359,"passed":1109,"failed":13,"version":"1.0.3.12"}
{"total":1359,"passed":1146,"failed":13,"version":"1.0.3.12"}
{"total":1359,"passed":1168,"failed":13,"version":"1.0.3.12"}
{"total":1359,"passed":1210,"failed":13,"version":"1.0.3.12"}
{"total":1359,"passed":1241,"failed":35,"version":"1.0.3.12"}
{"total":1359,"passed":1245,"failed":79,"version":"1.0.3.12"}
{"total":1359,"passed":1267,"failed":89,"version":"1.0.3.12"}
Tests completed in 38.47 seconds
Test Suite Complete
Full run log written to /home/jerome/Projets/lrs-conformance-test-suite/logs/a7a0c76c-d615-4f6e-bc8a-b7ac3b3a36d5.log
(node:24677) [DEP0013] DeprecationWarning: Calling an asynchronous function without callback is deprecated.
Closed

Plus the details of each request (what has been sent and what has been received) are not in the log file anymore.

[Lctrs]

I'm using the up-to-date development branch.

[Andy Creighton]

Thanks we'll look into it.