Class Design: Encapsulation
adilanchian opened this issue · comments
Feedback: "The fact that everything was effectively public makes the responsibility of each class difficult to understand. The fact that everything was accessible by another class makes the communication model very difficult to enforce, and will likely lead to a lot of hard to find bugs as the codebase gets bigger"
- Specify which properties/methods should be private or public
- Create struct that will hold constants instead of just a global file
Just added some awesome tweaks in this commit.
Need to look into each and figure out what classes need to access another and create a way to do this efficiently.
I believe I have finished with this task and am ready to merge into merge-review