Trigger is encoded twice

Question

Trigger is encoded twice

eliasborngaesser opened this issue 10 months ago · comments

eliasborngaesser commented 10 months ago

Because the input is already encoded from the setTrigger function, the encodeNewLines function is called twice.
This leads to \n inside the value of the trigger

https://github.com/adamgibbons/ics/blob/ecc8cf54f84da92b3a0fe0fa049fc65cda4d1451/src/utils/set-alarm.js#L58C26-L58C26

Tom Jenkinson · Answer 1 · Wed Dec 20 2023 20:45:53 GMT+0800 (China Standard Time)

@eliasborngaesser have you got an example? calling encodeNewLines twice shouldn't cause a problem 🤔

Tom Jenkinson · Answer 2 · Wed Dec 20 2023 20:46:28 GMT+0800 (China Standard Time)

Ah I see it now will open a PR