adamchainz / django-cors-headers

Django app for handling the server headers required for Cross-Origin Resource Sharing (CORS)

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Replace use of WHITELIST with ALLOWLIST

pmalmgren opened this issue · comments

I've noticed that this project uses WHITELIST for the two settings CORS_ORIGIN_WHITELIST and CORS_ORIGIN_REGEX_WHITELIST.

I propose that these be changed to CORS_ORIGIN_ALLOWLIST and CORS_ORIGIN_REGEX_ALLOWLIST.

Besides the problematic use of WHITELIST, I've also noticed that ALLOW is used in several other configuration settings, so this change would make the settings more consistent and readable as well.

If given the 👍 from @adamchainz I'd be happy to open a PR and make this change here myself.

One thing I'd like to add: thanks for this project. It's great and has saved me a ton of time when implementing CORS in one of my projects. Cheers 😄

PR #531 already adds this, I will try find the time to merge it in the coming week.