adamchainz / django-cors-headers

Django app for handling the server headers required for Cross-Origin Resource Sharing (CORS)

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Removal of corsheaders.models

neilhut42 opened this issue · comments

It just broke for us, with latest commit I can see why. Did it really have to be removed?

No problems if it did, just letting you know we were using it...

Hey @neilhut42 !

Did you read the changelog associated with the release 3.0.0? My explanation for the removal is there.

I think it shouldn't be too hard to migrate to a model inside your application, using the signal is well documented.

Thanks,

Adam

Thanks for your follow-up - - I did read it, after it broke our builds - my fault for not pinning the version number I guess.

Always pin! I recommend https://github.com/jazzband/pip-tools or pipenv.

If/when you migrate to version 3.0.0, please share any update you can for the changelog about how you migrated, to make it easier for others.

Thanks,

Adam