do not set default port if not set

Question

do not set default port if not set

yellowbrickc opened this issue 7 years ago · comments

Hi,
we use an HBase/Rest-Service on AWS and we don't have a port to supply as option. What do you think about the idea to only set the fallback if the host is missing too or is set to localhost?

We would implement this if it's ok for you.

Cheers

Worms David · Answer 1 · Mon Jul 10 2017 04:52:50 GMT+0800 (China Standard Time)

Hi, what do you mean by "we don't have a port to supply as option"

Krisztina Hirth · Answer 2 · Mon Jul 10 2017 19:28:46 GMT+0800 (China Standard Time)

I meant fix endpoints, without a port.
Doesn't matter anyway, PR52 fixes this problem.
BTW the issuer kubikb is my colleague :)

It would be cool if you could release a new npm-package during this week.
Thanks a lot.

Worms David · Answer 3 · Tue Jul 11 2017 04:32:42 GMT+0800 (China Standard Time)

Great, he did a fantastic job. I wasn't sure what you meant by endpoint, the URL ? Glad that the issue is fixed. The release is published