adafruit / Adafruit_Si5351_Library

Driver for Adafruit's Si5351 Clockgen Breakout

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

divider is limited to 3 < div < 901 while AN619 and AN1234 state a range of 8+1/xxx to 2048

thefloe1 opened this issue · comments

ASSERT(div > 3, ERROR_INVALIDPARAMETER); /* Divider integer value */

divider is limited to 3 < div < 901 while AN619 and AN1234 state a range of 8+1/xxx to 2048

commented

Not exactly. AN619. page 2:

Valid Multisynth divider ratios are 4, 6, 8, and any fractional value between 8 + 1/1,048,575 and 2048.

Multisynth integer divisor can be less than 8: 4 or 6. In my experience, 4 or 6 works if the fractional part is set to 0/1, regardless of the multisynth working in fractional or integer mode.

right, sorry marked the wrong line here. Should have been line 402 and the upper limit is the main concern:

ASSERT(div < 901, ERROR_INVALIDPARAMETER); /* Divider integer value */

I created a pull request to change the upper limit to 2048

Hi Team, how can this update also be applied to Arduino Library? It has been updated in Raspberry Pi library v 1.2.7.

This works! Thanks so much @ladyada