SI5351 library: The errors are not correctly handled.

[Alexandre]

Hi,

After doing all the checks.

If you're sure this issue is a defect in the code and checked the steps above
please fill in the following fields to provide enough troubleshooting information.
You may delete the guideline and text above to just leave the following details:

• Arduino board: INSERT ARDUINO BOARD NAME/TYPE HERE
  Arduino nano 328p (old bootloader)

• Arduino IDE version (found in Arduino -> About Arduino menu): INSERT ARDUINO
  VERSION HERE
  Visual Studio Code : PlatformIO (core 5.1.1 home 3.3.4) : Library 1.2.1
  Version: 1.55.2 (user setup)
  Commit: 3c4e3df9e89829dce27b7b5c24508306b151f30d
  Date: 2021-04-13T09:35:57.887Z
  Electron: 11.3.0
  Chrome: 87.0.4280.141
  Node.js: 12.18.3
  V8: 8.7.220.31-electron.0
  OS: Windows_NT x64 10.0.19042

• List the steps to reproduce the problem below (if possible attach a sketch or
  copy the sketch code in too): LIST REPRO STEPS BELOW
  I installed the SI5351 library which goes with the Adafruit module (https://www.adafruit.com/product/2045).

Following your example (lines 16-22), I used the piece of code which tests the I²C connection through wire.begin () included in the library's CPP.

I noticed that from the moment the module is not plugged in, no error was found. However in your example, we are seen to see appear "Ooops, no Si5351 detected ... Check your wiring or I2C ADDR!" ; instead the code continues its path to loop ().

So I went into the bookstore to see what was going on. There is the presence of an "errors.h" file which contains a list of errors which must be reported.

Unfortunately, in your Adafruit_SI5351.cpp code, no error is encoded. The "errors.h" file is useless.

We first discuss the topic in the forum before coming back here to resolve the issue. (See thread: https://forums.adafruit.com/viewtopic.php?f=41&t=178571&p=869976#p869976)

Thank you in advance for your help on this subject.

Regards,
Alex

[Carter Nelson]

Should be taken care of with #13.