Error in IR example for CPX
bradanlane opened this issue · comments
In the learning guide for the Circuit Playground Express, IR CPX to CPX example, the code has the following:
encoder = adafruit_irremote.GenericTransmit(header=[9500, 4500], one=[550, 550], zero=[550, 1700], trail=0)
However, the sample code from adafruilt_irremote.py
has the following:
encoder = adafruit_irremote.GenericTransmit(header=[9000, 4500], one=[560, 1700], zero=[560, 560], trail=560)
The CPX example results in the receive data being the 1s compliment of the send data.
Could you submit a PR for this? Thanks. That would be the easiest way to make sure it's corrected properly.
OK, I forked the learning guides and went to make the change and found the same error in four different guides.
This has caused me to be concerned. I can only assume one of three possible situations:
- those guides were not tested (seems unlikely)
- those guides somehow work but only with themselves (i.e. they somehow have the reciprocal error of the receive ... but I could not find that to be the case)
- something has changed since those guides were written (most are 2+ years old)
I am happy to submit the pull request but I would like another set of eyes to scrutinize the changed code. I do not have a Circuit Playground Express on hand and do not have the irRobotControl board(s).
I performed my testing using a Raspberry Pi PICO and the Adafruit IR Receiver board and IR Emitter board.