adafruit / Adafruit_Learning_System_Guides

Programs and scripts to display "inline" in Adafruit Learning System guides

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

change workflow concurrency group names to avoid GA weirdness

jepler opened this issue · comments

I received an update from GH support about our problem where the image updater is cancelled ...I think we can change our workflow files so that this doesn't happen.

Thank you for your patience while the team investigated this.

I have been updated that the workflow runs are actually getting canceled by pages-build-deployment runs. For example, https://github.com/adafruit/Adafruit_Learning_System_Guides/actions/runs/3376580648 was canceled by https://github.com/adafruit/Adafruit_Learning_System_Guides/actions/runs/3376591433.

pages-build-deployment actually also uses concurrency group feature under the cover to prevent multiple pages build from running. It currently uses the source branch name as group name.

This scheduled workflow has a job that pushes to the branch folder-images. This push will trigger pages-build-deploymentworkflow. Pages workflow will start running also using folder-images as concurrency group name because it’s on folder-images branch. If pages workflow started before the scheduled workflow fully completes, it will attempt to cancel the scheduled workflow causing the scheduled workflow to report cancelled status.

The Pages team will work on changing the concurrency group name they use in pages-build-deployment to something less generic to avoid collisions like this in the future.

As a workaround in the meantime, could you use a different concurrency group name in your scheduled workflow to mitigate this issue?

I hope this helps, please let us know if you need any further assistance.