Small error in examples/matrix.py
elmwoodelec opened this issue · comments
Elmwood Electronics commented
Line 23 should show:
#matrix = matrix.Matrix8x8x2(i2c)
Radomir Dopieralski commented
Great find, do you think you could propose a pull request with a fix? We can help.
Elmwood Electronics commented
Hi Randomir,
I'm pretty new to GitHub so I'm not sure if I did it right, but I think I
just made a pull request.
thanks,
Craig
…On Thu, May 24, 2018 at 5:16 PM, Radomir Dopieralski < ***@***.***> wrote:
Great find, do you think you could propose a pull request with a fix? We
can help.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AY7lxWfsNY9kE69u7dvmD521ulpLqy7Lks5t1yMYgaJpZM4UM_a4>
.
--
Craig LeMoyne
Cofounder, Elmwood Electronics <http://elmwoodelectronics.ca/>
(416)836-2200
@elmwoodelec <https://twitter.com/elmwoodelec>
Carter Nelson commented
hey @elmwoodelec, not seeing the PR. the basic process is:
- fork this repo
- make edits in your forked copy
- submit a PR from the fork to this repo
did you do something like that?
Carter Nelson commented
PR received and merged. Thanks for finding and fixing that.