v2.2.2 is broken

Question

v2.2.2 is broken

crimx opened this issue 7 years ago · comments

It seems like the Github project is published to NPM. require('sinon-chrome/extensions') and require('sinon-chrome/webextensions') break on v2.2.2.

And #69 is not correctly built.

Aleksey Tsvetkov · Answer 1 · Thu Jan 18 2018 01:01:35 GMT+0800 (China Standard Time)

just a minute

Aleksey Tsvetkov · Answer 2 · Thu Jan 18 2018 01:07:13 GMT+0800 (China Standard Time)

try this one
https://www.npmjs.com/package/sinon-chrome v2.2.3

CRIMX · Answer 3 · Thu Jan 18 2018 01:19:08 GMT+0800 (China Standard Time)

Thanks @acvetkov . #69 is fixed but require('sinon-chrome/extensions') and require('sinon-chrome/webextensions') are still broken.

I think "main": "out/index.js" in package.json should be changed to "main": "index.js".

And npm publish within ./out.

Aleksey Tsvetkov · Answer 4 · Thu Jan 18 2018 02:29:03 GMT+0800 (China Standard Time)

Fantastic fail.

I will fix tomorrow.