actumn / celery.node

Celery task queue client/worker for nodejs

Home Page:https://celery-node.js.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Updating amqplib dependency

cjmaria opened this issue · comments

Hello, I am using celery.node in an application built with the latest version of node.js. Whenever I run npm install, I get warnings related to ampqlib having an unsupported node version:

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'amqplib@0.5.6',
npm WARN EBADENGINE   required: { node: '>=0.8 <=12' },
npm WARN EBADENGINE   current: { node: 'v15.11.0', npm: '7.6.0' }
npm WARN EBADENGINE }

This can be resolved by updating celery.node to use the latest version of ampqlib which supports newer node.js versions. Is there any reason why you use ampqlib 0.5.6?

Hi, cjmaria!
Thank you for reporting the issue.

There's no special reason that celery.node uses the specific version.
It was just the latest version when I created it.

It would be greatly appreciated if you make a pull request to bump it.

Hey,

Im going to submit a PR which just includes an update of this dependency - as it is throwing a high importance vulnerability warning.

Thanks

@daffron Thank you :)