Make actix-rt (and actix itself) work with tokio console
msdrigg opened this issue · comments
When using tokio-console, all tasks run in actix-rt appear meaningless because they look like they are being run from the same line (see image below for illustrations). This issue used to be a tokio issue, but this was just fixed in this pr (tokio-rs/tokio#4483).
Now, have looked into where actix-rt could add "track_caller" attributes to different functions to have the same effect as tokio, but I don't know if this will work due to how actix-rt spawns futures by sending them across channels to arbiters.
At least actix-rt could add track_caller
to a few key functions and this would greatly improve usability.
actix-net/actix-rt/src/system.rs
Line 208 in d229c1e
actix-net/actix-rt/src/system.rs
Line 235 in d229c1e
actix-net/actix-rt/src/runtime.rs
Line 56 in d229c1e
actix-net/actix-rt/src/runtime.rs
Line 76 in d229c1e
Line 202 in d229c1e
Duplicate of actix/actix-web#2646. Fine to keep it open though since the change will need to happen here.