Adding limit to PostgreSQL query broken

Question

Adding limit to PostgreSQL query broken

kennym opened this issue 12 years ago · comments

When specifying a limit argument (bundle exec etl etl/run_all.ebf --limit 5) with a value against a PostgreSQL source database, I am retrieving the following error:

activewarehouse-etl-1.0.0.rc1/lib/etl/control/source/database_source.rb:197:in `query': undefined method `add_limit_offset!' for #<ActiveRecord::ConnectionAdapters::PostgreSQLAdapter:0x007fe9cf329248> (NoMethodError)

I haven't tried it on other databases sources.

The add_limit_offset method is seemingly deprecated for some time already in newer Rails versions: http://apidock.com/rails/ActiveRecord/ConnectionAdapters/DB2Adapter/add_limit_offset!

Thibaut Barrère · Answer 1 · Mon Apr 23 2012 21:21:41 GMT+0800 (China Standard Time)

Good catch! Let me know if you come up with a patch (or I'll dive later on).

Kenny Meyer · Answer 2 · Mon Apr 23 2012 21:45:56 GMT+0800 (China Standard Time)

This fixes the issue with PostgreSQL at least. I can add tests tonight (in about 6 hours from now) if needed.

Thibaut Barrère · Answer 3 · Mon Apr 23 2012 22:47:40 GMT+0800 (China Standard Time)

Thanks! Tests are most welcome too; but let me know if you're stuck with how to run them etc!

Kenny Meyer · Answer 4 · Wed Apr 25 2012 00:01:20 GMT+0800 (China Standard Time)

Pull request sent! :)

Thibaut Barrère · Answer 5 · Wed Apr 25 2012 00:02:06 GMT+0800 (China Standard Time)

Thanks!

Envoyé de mon iPhone

Le 24 avr. 2012 à 18:01, Kenny Meyer
reply@reply.github.com
a écrit :

Pull request sent! :)

Reply to this email directly or view it on GitHub:
#92 (comment)