activewarehouse / activewarehouse-etl

Extract-Transform-Load library from ActiveWarehouse

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Foreign Key Lookup Transform doesn't set the field to nil if resolver fails

colinux opened this issue · comments

Hello,

If a resolver fails, a ResolverError is raised (in foreign_key_lookup_transform.rb#L47).
This exception is catched in engine.rb#L385, but nil has not been set to the field (row[name] has not been updated line 382 because of the exception).

Is this the excepted behavior and the doc is wrong or is it a bug? (and I probably could propose a PR)

Thanks!

Hi!

I need to verify what's the historically expected behaviour on existing project - will let you know!

-- Thibaut