acquia / moonshot

Moonshot: Because releasing services shouldn't be a moonshot!

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

nilreference in AWS response at `handle_deployment_failure`

borsothy opened this issue · comments

We've encountered this issue in our system test:
/home/jenkins/jobs/workspace/cd-system-test/cloud-database-api/vendor/bundle/ruby/2.2.0/bundler/gems/moonshot-ab988dd32eea/lib/moonshot/deployment_mechanism/code_deploy.rb:294:in 'block (2 levels) in handle_deployment_failure': undefined method 'message' for nil:NilClass (NoMethodError)

The problem occurs right here. As you can tell from the exception, event.diagnostics was nil. I have opened an AWS support ticket, and the anwser was

you might get a nil value if there is nothing to return regarding from the lifecycle event chain

The function is present both in 1.x and 0.7.x. @askreet, @glennpratt and all Moonshot folks, let me know what you think.