Non-USD lot currency confuses valuation logic
yznts opened this issue · comments
Describe the bug
When lot currency is not USD (but USD selected as a base display currency), valuation logic still thinks it's USD.
To Reproduce
Steps to reproduce the behavior:
- Add any non-USD lot
Expected behavior
Take into account lot currency.
Screenshots
Environment (please complete the following information):
- OS: Mac
- Terminal: iTerm
- Terminal Version: 3.4.15
- ticker Version: 4.5.1
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.
After messing around with this issue, it seems that it's caused by Yahoo incorrectly formatting the London stock exchange quote currency as GBp instead of GBP, which causes currency conversion error. The same error occurred with London stocks when using CAD as display currency.
I've submitted a pull request #231
Thanks again for the fix @deroshkin this is addressed in the latest release