abseil / abseil-cpp

Abseil Common Libraries (C++)

Home Page:https://abseil.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Consider using ThrowBadAllow on allocation failures

coryan opened this issue · comments

Describe the bug

Consider this failure:

ABSL_RAW_LOG(FATAL, "mmap error: %d", errno);

This seems like an allocation failure, maybe it would be better to use this

https://github.com/abseil/abseil-cpp/blob/master/absl/base/internal/throw_delegate.h#L62

?

Steps to reproduce the bug

N/A

What version of Abseil are you using?

Latest LTS

What operating system and version are you using

Linux, all distros.

What compiler and version are you using?

Seems to apply to all compilers.

What build system are you using?

N/A

If that fails, something is very wrong, and I'm not sure it is possible or safe to recover from such a failure.