Change member variable prefix in LoginActivity.java

Question

Change member variable prefix in LoginActivity.java

abhijitparida opened this issue 6 years ago · comments

Prefix all member variables in LoginActivity.java with this. and remove the m prefix.

For example,

mContext

becomes

this.context

File location: /app/src/main/java/app/abhijit/iter/LoginActivity.java

If this is your first pull request, read this article: (https://www.digitalocean.com/community/tutorials/how-to-create-a-pull-request-on-github). Make sure all test cases pass before submitting your pull request.

Happy Hacktoberfest! 🔥

Jashaswee Jena · Answer 1 · Fri Oct 12 2018 17:08:03 GMT+0800 (China Standard Time)

Hello! Can I work on this issue?

Thank you!

Abhijit Parida · Answer 2 · Fri Oct 12 2018 17:12:08 GMT+0800 (China Standard Time)

Yeah sure!

Jashaswee Jena · Answer 3 · Fri Oct 12 2018 18:22:10 GMT+0800 (China Standard Time)

Facing this while doing a project sync. If only I add

google()

in the

allprojects {
repositories {
...
}
}

section in root level build.gradle it stops throwing that error. Should I add that?

Sorry for the inconvinience!

Abhijit Parida · Answer 4 · Fri Oct 12 2018 18:45:09 GMT+0800 (China Standard Time)

Add it, but submit a different pull request for that.

Jashaswee Jena · Answer 5 · Fri Oct 12 2018 18:58:12 GMT+0800 (China Standard Time)

Add it, but submit a different pull request for that.

Did do that. Can you please check?

Jashaswee Jena · Answer 6 · Fri Oct 12 2018 19:02:16 GMT+0800 (China Standard Time)

Another problem I was facing was even though the app builds fine and installs on my device, yet still, I weirdly am not able to log in using my credentials. I tried uninstalling it and installing the one on play store and it works just fine. I guess some previous commit broke the login functionality. I did not touch anything else but just fix gradle sync.

Thank you!

Abhijit Parida · Answer 7 · Fri Oct 12 2018 19:08:12 GMT+0800 (China Standard Time)

Did do that. Can you please check?

Merged 👍

Another problem I was facing was even though the app builds fine and installs on my device, yet still, I weirdly am not able to log in using my credentials. I tried uninstalling it and installing the one on play store and it works just fine. I guess some previous commit broke the login functionality. I did not touch anything else but just fix gradle sync.

Thank you!

Debug builds are configured not to make API requests to ITER servers. You can use any username (provided that it contains 10 digits) and the password must be password.

See: https://github.com/abhijitparida/bunk#contributing

Jashaswee Jena · Answer 8 · Fri Oct 12 2018 19:10:00 GMT+0800 (China Standard Time)

Debug builds are configured not to make API requests to ITER servers. You can use any username (provided that it contains 10 digits) and the password must be password.

Ahh. Would get on working through this issue right away!
I'm sorry I did not read the contributing guidelines.

Thank you!