abenz1267 / walker

Application launcher similar to Rofi etc. . Wayland native.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Many icons missing?!

RoccoRakete opened this issue · comments

There are many icons missing in the applications list. I don't know if it has anything to do with these errors?!

Screenshot_29-03-24_12-13

You need to provide more information:

  • What's your GTK4 theme?
  • What's your icon theme?
  • example *.desktop file of an app with missing icon

(the errors in console are irrelevant)

If it's relevant, anyrun and wofi are working fine.

Let me know if you need anything else!

Both anyrun and wofi are GTK3. Walker is GTK4.

I've installed the GTK theme and icon theme.. also installed boxbuddy and geary. No problems.

I've changed the way icons are loaded in order to catch errors... can you checkout the latest version, start via terminal and see if there's an icon-related error showing up?

This issue only seems to affect Nix users... on Arch stuff is fine.

Not fixed unfortunately.

Screenshot_29-03-24_14-40

I've just pushed an update letting you explicitly set an icon theme... can you try that? I don't know what kinda problem nix and gtk4 have with icons....

"icons": {
"theme": "<theme>"
}

Still the same.

image

Ok, can u do this for me? Put the following into example.c:

#include <gtk/gtk.h>

static void
activate (GtkApplication* app,
          gpointer        user_data)
{
  GtkWidget *window;
  GtkWidget *icon;
GtkWidget *box;

    icon = gtk_image_new_from_icon_name ("org.gnome.Geary");

  window = gtk_application_window_new (app);

box = gtk_box_new (GTK_ORIENTATION_HORIZONTAL, 0);
  gtk_window_set_child (GTK_WINDOW (window), box);
    gtk_box_append (GTK_BOX (box), icon);

  gtk_window_set_title (GTK_WINDOW (window), "Window");
  gtk_window_set_default_size (GTK_WINDOW (window), 200, 200);
  gtk_window_present (GTK_WINDOW (window));
}

int
main (int    argc,
      char **argv)
{
  GtkApplication *app;
  int status;

  app = gtk_application_new ("org.gtk.example", G_APPLICATION_DEFAULT_FLAGS);
  g_signal_connect (app, "activate", G_CALLBACK (activate), NULL);
  status = g_application_run (G_APPLICATION (app), argc, argv);
  g_object_unref (app);

  return status;
}

compile it via: gcc $( pkg-config --cflags gtk4 ) -o example example.c $( pkg-config --libs gtk4 ) .

Run ./example.

This should show the geary icon.

Sure. But I'm getting this.

EDIT: In case you can't see this: It's the same placeholder symbol, as shown by walker.

Screenshot_29-03-24_19-01

Yeah, ok... for me this is good news: the issue is not related to Walker. I'm sorry.

Guess you need to ask Nix people why it's broken.

Closing, as it's not related to Walker.

Okay, so maybe @diniamo knows this? Since he packaged it for nix?

It shouldn't have anything to do with the Nix package. I have no idea.

If walker uses the builtin methods of gtk, or some xdg library, I can't help you.

@RoccoRakete you should open an issue with Nix (github? their forum?) and provide the little C example from above.

Yes, I already opened an issue with this discussion linked.

Can you link it here so i can follow? There'll be more users and having a place to point them to would be good.

It's over at the nixOS Discord ID is: 1223334083556409555