abacusorg / abacusutils

Python code to interface with halo catalogs and other Abacus N-body data products

Home Page:https://abacusutils.readthedocs.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add support for OSX

AlexGKim opened this issue · comments

It seems that os.sched_getaffinitycalled in the enclosed link is not supported by OSX. Or at least it doesn't work on my laptop.

I am running Python 3.8.8

DEFAULT_BLOSC_THREADS = max(1, min(len(os.sched_getaffinity(0)), DEFAULT_BLOSC_THREADS))

Thanks for the report! I haven't done any testing on OSX; this bug is easy enough to fix, but I have no clue if the rest of the code is OSX-safe. I'll add a CI config so we can find out.

@AlexGKim Unfortunately the tests don't pass on OSX, even after fixing the bug you reported (https://github.com/abacusorg/abacusutils/runs/7471117270?check_suite_focus=true). I don't have an OSX platform to debug on, so for now I don't think we'll be able to support OSX. But if you're feeling motivated to dig into this issue, we would welcome the contribution and I'd be happy to advise your debugging!

I'm also going to rename the issue to reflect the current state of the problem.

Hi @lgarrison . I had code that only had to be run once that got run on a UNIX machine. So my personal issue is solved. I will dig more deeply into this if the need arises.