aave / aave-utilities

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Modify `signERC20Approval` for non-standard permit tokens

defispartan opened this issue · comments

signERC20Approval is used to generate the signature payload for methods which support permit. A lot of tokens have permit features disabled because they do not implement the EIP-2612 interface.

After reviewing all tokens, there are 0 which are currently disabled but could be enabled with a small change to the signature request.

OP - Optimism
AAVE - Optimism
DAI - Optimism
DAI - Arbitrum
EURS - Arbitrum
FRAX - Avalanche
USDC - Avalanche
USDC - Polygon
USDC - Mainnet

Despite the EIP-2612 specs saying that the nonce value should be current, all of these token check that the nonce + 1, so nonce should be incremented in signERC20Approval for these tokens as well.

Would love for USDC on Polygon to be enabled. 🤞
(and Base)