required timestamps
sakulstra opened this issue · comments
In the current version of @aave/protocol-js we have a lot of non required timestamps where we then default to Date.now() or similar.
This caused a few issues in the past with wrong system clocks and shit like that. While making these field required won't necessarily solve these issues it will make debugging them easier.
Imo low level utility library should be as explicit as possible - if a method needs the currentTimestamp to perform it's math it should be a required field, not optional.
This was previously discussed and decided - if you disagree though, feel free to comment.
there should be no more cases of this