Giters

aave / Aave-Vault

ERC4626 vault to hold aToken assets

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Inconsistent use of returned values

miguelmtzinf opened this issue · comments

commented

Some functions are giving names to the return variable of the function, some not.

https://github.com/aave/wrapped-atoken-vault/blob/8473a3cb8cd167c6c894c7721f45ec95e21bffcc/src/ATokenVault.sol#L296-L302

https://github.com/aave/wrapped-atoken-vault/blob/8473a3cb8cd167c6c894c7721f45ec95e21bffcc/src/ATokenVault.sol#L359-L361

While our convention is not to give names to return variables, we can follow that approach to stay as close as possible to the ERC4626 for those functions that are part of the standard. We can follow our convention in the other cases.