aaranxu / adidoks

In two places, there is a check if a certain keydown event was triggered by the 191 key code to e.g. focus on the input search bar. Even though I think this is wrong or at least might not work on every machine.

At least on my (Ubuntu) Machine, using Brave Browser typing / doesn't result in the key code 191 but in 55 which is the keyCode for 7.

So instead of checking for the keyCode in the two places mentioned further down, but also in the other places I would suggest to use the event.key property instead.
So I would replace e.keyCode === 191 with e.key === '/'.

I verified with the following snippet, that it works accordingly. Also you can see that I type in / but the keyCode 55 is printed to the console.
Also after changing this locally the focus on the search input worked again.

document.addEventListener('keydown', function(e){
    console.log(e.keyCode);
    console.log(e.key);
});

The two places:

adidoks/static/index.js

Line 8 in 6887e4e

if (e.keyCode === 191 ) {

adidoks/static/js/search.js

Line 8 in e03e8a5

if (e.keyCode === 191

I don't mind preparing a PR/fix for the 191 case, but can also do so for the other ones.

Wrong keycode for focusing the search (I can prepare a PR)