aangelopoulos / conformal-prediction

Lightweight, useful implementation of conformal prediction on real data.

Home Page:http://people.eecs.berkeley.edu/~angelopoulos/blog/posts/gentle-intro/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Predictive uncertainty in weather-time-series-distribution-shift notebook

CheeGY opened this issue · comments

commented

First of all, I would like to thank all contributors to this repository. Appreciate the great work that goes behind creating and maintaining this repository.

I was looking through the notebook, weather-time-series-distribution-shift.ipynb, and notice that in the last 4 lines of the second section, we have:
sort_idx = np.argsort(times)
pred_mean = pred_mean[sort_idx]
temperatures = temperatures[sort_idx]
times = times[sort_idx]

Should the sorting also be done for the uncertainty data, i.e., by adding the line pred_uncertainty=pred_uncertainty[sort_idx]?

Nice catch, thanks so much!

Fixed in commit dc506f8e1b0e597021603bb702a2fb190b5ab4fd