aamini / introtodeeplearning

Lab Materials for MIT 6.S191: Introduction to Deep Learning

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Lab 1 Part 1.1] A typo in the matrix indexes?

datasith opened this issue · comments

The last matrix defined by the user in section 1.1 has to be a 2-d Tensor. Thus, it'll have a shape of (n, 2) or (2, n). The code in the Lab 1 notebook has:

row_vector = matrix[1]
column_vector = matrix[:,2]
scalar = matrix[1, 2]

This assumes the column-rank to be >=3. IMHO, it should instead be:

row_vector = matrix[1]
column_vector = matrix[:,1]
scalar = matrix[0, 1]

And assume the user will choose a (2,2) matrix as their solution.

See PR #59 for more details on the issue.