Giters

aalhour / C-Sharp-Algorithms

:books: :chart_with_upwards_trend: Plug-and-play class-library project of standard Data Structures and Algorithms in C#

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Multiple issues with catalan numbers

nickntg opened this issue · comments

commented

Specifically:

  • The algorithm does not produce correct numbers when large ranks are used.
  • The implementation of GetNumberByBinomialCoefficients() produces different results when rank >= 32.
  • As a result of the above, CatalanNumbersTest.DoTest() fails.
  • There are no tests to validate the algorithm implementation against known and documented catalan numbers.
commented

Closing this as #75 is now merged.