aachman98 / Sorcar

Procedural modeling in Blender using Node Editor

Home Page:https://aachman98.itch.io/sorcar

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[BUG]

sebastian1111 opened this issue · comments

Describe the bug
Different error windows

To Reproduce
For example just adding the node Create Circle and then adding the modifier Array will throw this error window. And sometimes the error will appear only when I added the second Array modifier and pressed preview.
Also the error messages can differ sometimes but they all have the same basic text like "Traceback (most recent call last)" and ending with "location: :-1"

Desktop :

  • OS: Windows 10

  • Blender Version 2.90

  • Blender 2.90.1 - the last version just downloaded - has the same errors
    But strangely in Blender 2.82 - it seems to be working without errors.

  • Sorcar Version 3.2.1

Additional context
Traceback (most recent call last):
File "C:\Users\tdk\AppData\Roaming\Blender Foundation\Blender\2.90\scripts\addons\sorcar\operators\ScExecuteNode.py", line 19, in execute
curr_tree.execute_node()
File "C:\Users\tdk\AppData\Roaming\Blender Foundation\Blender\2.90\scripts\addons\sorcar\tree\ScNodeTree.py", line 77, in execute_node
if (not n.execute()):
File "C:\Users\tdk\AppData\Roaming\Blender Foundation\Blender\2.90\scripts\addons\sorcar\nodes_base\node_base.py", line 57, in execute
self.node_error = not self.init_out(self.post_execute())
File "C:\Users\tdk\AppData\Roaming\Blender Foundation\Blender\2.90\scripts\addons\sorcar\nodes_base\node_modifier.py", line 28, in post_execute
bpy.ops.object.modifier_apply(apply_as='DATA', modifier=self.prop_mod_name)
File "D:\Blender_2.90_\Release\2.90\scripts\modules\bpy\ops.py", line 201, in call
ret = op_call(self.idname_py(), None, kw)
TypeError: Converting py args to operator properties: : keyword "apply_as" unrecognized

location: :-1

I just installed "Animation Nodes" and this seems to be working fine, no errors.

I applied your fix for the Array modifier and the errors disappeared but now I see an error for the bevel modifier. And I'm guessing for other modifiers too. I will try to apply the same fix to those too, but I have no idea about scripts and modifying them.

As the release note of Blender 2.90 states, the apply_as argument of modifier.apply() method has disappeared and the new modifier.apply_as_shapekey() method appeared.
Quite a sad change IMO, since many addons now have to fix this issue, and in some cases have to branch what was formerly a single line of code.

See https://wiki.blender.org/wiki/Reference/Release_Notes/2.90/Python_API

With the advice from the other bug report posted here

in node_modifier.py
"Replace it with: bpy.ops.object.modifier_apply(modifier=self.prop_mod_name)"

the problem was fixed for the array modifier.
Is there a simple fix for the other modifiers too, something I can replace in notepad ?