a8m / angular-filter

Bunch of useful filters for AngularJS (with no external dependencies!)

Home Page:https://github.com/a8m/angular-filter

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

KiB and MiB are wrongly used in place of kB and MB

evilaliv3 opened this issue · comments

The current implementation for byteFmt and kbFmt is using KiB(kibibyte) and MiB (mebibyte) are wrongly used in place of kB(kilobyte) and MB (megabyte).

The issue should be fixed in compatibility with the most common convension of softwares like the linux filesystem, chrome, firefox.

Evidences of the issue are present on the following ticket: globaleaks/GlobaLeaks#2044

A diffuse explaination is present on the wikipedia page: https://en.wikipedia.org/wiki/Kilobyte

image

In the real only linux and mac use the correct Kb definitions while Microsoft still use the 1024 size so that it is not possible to obtain something completely "correct".

It might be better to modify the filters to take a second parameter which is the base 10 or 2.