Compilation fails on 32bit devices
ogres opened this issue · comments
When trying to compile MessagePack for 32 bit ( iOS ) devices, following lines fail on Integer overflow
https://github.com/a2/MessagePack.swift/blob/master/Sources/MessagePack/Pack.swift#L29
https://github.com/a2/MessagePack.swift/blob/master/Sources/MessagePack/Pack.swift#L123
https://github.com/a2/MessagePack.swift/blob/master/Sources/MessagePack/Pack.swift#L153
https://github.com/a2/MessagePack.swift/blob/master/Sources/MessagePack/Pack.swift#L91
https://github.com/a2/MessagePack.swift/blob/master/Sources/MessagePack/Pack.swift#L108
Tested on Xcode 9, Swift 3.2
@ogres @n3trino I'm trying to reproduce the issue with Xcode 9 but I don't have a 32-bit iOS device. Is it possible to reproduce with the simulator at all?
Try making an archive with armv7 architecture enabled
Hmm, I'm able to build an armv7 framework on my machine.
I am able to reproduce this on an empty project.
- Create new iOS project
- Set min iOS version to 9
- Install MessagePack via CocoaPods
- Set Swift lang to 3.2 for MessagePack.swift target ( and 4.0 for the project itself )
- Select 'Generic iOS Device' in devices list
- Project -> Archive
Hello @a2 ,
Have you tried to archive? The issue appears when you archive a project and not when you build and run either on simulator or on device.
Ah I see the problem. This was fixed with PR #53 but I hadn't tagged a new release. Will do so later today.
I just pushed version 2.1.1 to CocoaPods. Let me know if this is still an issue. 😄
Works fine on 32 bit device, Thanks @a2