Giters

a0rtega / pafish

Pafish is a testing tool that uses different techniques to detect virtual machines and malware analysis environments in the same way that malware families do

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

utils.c - bug in pafish_check_mac_vendor

asafcyi opened this issue · comments

commented

Hi,
I've noticed that in "pafish_check_mac_vendor" function in utils.c there is a potential problem:
palist pointer is advanced (line 167: palist = palist->Next;) and freed using LocalFree (lines: 163, 169).
It caused the program to crash.
I recommend to keep a pointer to the start of the allocated buffer and free it before leaving the function.
Thanks for this great tool!

commented

Hi,
I've just noticed the same exists for "pafish_check_adapter_name" function in utils.c.
BR,
Asaf.

commented

Hello there!

Thanks for your report, good catch! It has been fixed in the devel branch, it will be merged into master for the next release.

Cheers!

commented

Merged into master and released!