ZhikangNiu / encodec-pytorch

unofficial implementation of the High Fidelity Neural Audio Compression

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Test routine only logs metric of last dataloader item ?

darius522 opened this issue · comments

writer.add_scalar('Test/Loss_G', loss_g.item(), epoch)
writer.add_scalar('Test/Loss_Disc',loss_disc.item(), epoch)

Hey there! Thanks again for your effort on this repo. Very minor detail; it looks like the test function currently only logs the metrics for the last dataloader item (maybe I misunderstood how this plays out with DataParallel, if so my apology). Any reason behind that ?

yes, it only log the metrics for the last dataloader item (in rank 0 when use ddp). You can feel free to change it :)

Thanks for clarifying, just wanted to ensure I understood that right.